New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mercury 13.19.0 plat 7832 set entry flow #7057
Mercury 13.19.0 plat 7832 set entry flow #7057
Conversation
@@ -1009,7 +1013,8 @@ public static function reIndexCuePointEntry(CuePoint $cuePoint, $shouldReIndexTo | |||
public static function copyCuePointsToClipEntry( entry $clipEntry ) { | |||
$clipAtts = self::getClipAttributesFromEntry( $clipEntry ); | |||
//if clipConcat flow let batch job copy cue point | |||
if ( !is_null($clipAtts) && is_null($clipEntry->getClipConcatTrimFlow()) ) { | |||
$allowedFlows = array(EntryFlowType::CLIP_CONCAT, EntryFlowType::TRIM_CONCAT); | |||
if ( !is_null($clipAtts) && in_array($clipEntry->getFlowType(), $allowedFlows)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right.
if ( !is_null($clipAtts) && !in_array($clipEntry->getFlowType(), $allowedFlows))
@@ -220,9 +220,7 @@ protected static function getClipAttributesFromEntry(BaseObject $object) { | |||
*/ | |||
protected static function isClipConcatTrimFlow(BaseObject $object ) { | |||
if ( $object instanceof entry ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code conv issue - remove brackets
@@ -1009,7 +1013,8 @@ public static function reIndexCuePointEntry(CuePoint $cuePoint, $shouldReIndexTo | |||
public static function copyCuePointsToClipEntry( entry $clipEntry ) { | |||
$clipAtts = self::getClipAttributesFromEntry( $clipEntry ); | |||
//if clipConcat flow let batch job copy cue point | |||
if ( !is_null($clipAtts) && is_null($clipEntry->getClipConcatTrimFlow()) ) { | |||
$allowedFlows = array(EntryFlowType::CLIP_CONCAT, EntryFlowType::TRIM_CONCAT); | |||
if ( !is_null($clipAtts) && !in_array($clipEntry->getFlowType(), $allowedFlows)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of !is_null($clipAtts) , if($clipAtts) does the same and more readable , please change
No description provided.