PLAT-9256: we should cache thumbnail for non block and limit thumbnai… #7646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l capture access control actions
| @@ -102,13 +102,22 @@ public function __construct(entry $entry, $ksStr, $referrer, $contexts = array() | |||
| $this->applyContext(); | |||
| } | |||
|
|
|||
| public function hasRules($contextType = null) | |||
| public function hasRules($contextType = null, $actionTypes = null) | |||
There was a problem hiding this comment.
Why are you passing action type as array while its content is not referred (it is type boolean)?
| @@ -297,7 +297,11 @@ public function execute() | |||
| $referrer = kApiCache::getHttpReferrer(); | |||
| $ksStr = $this->getRequestParameter("ks"); | |||
| $secureEntryHelper = new KSecureEntryHelper($entry, $ksStr, $referrer, ContextType::THUMBNAIL); | |||
| $secureEntryHelper->validateForPlay(); | |||
| $enableCacheValidation = $secureEntryHelper->hasRules(ContextType::THUMBNAIL, array(RuleActionType::BLOCK,RuleActionType::LIMIT_THUMBNAIL_CAPTURE)); | |||
There was a problem hiding this comment.
This array here is useless.
| @@ -453,8 +457,8 @@ public function execute() | |||
| } | |||
|
|
|||
| $nocache = false; | |||
| if ($secureEntryHelper->shouldDisableCache() || kApiCache::hasExtraFields() || | |||
| (!$secureEntryHelper->isKsWidget() && $secureEntryHelper->hasRules(ContextType::THUMBNAIL))) | |||
| if ($enableCacheValidation && ($secureEntryHelper->shouldDisableCache() || kApiCache::hasExtraFields() || | |||
There was a problem hiding this comment.
can be optimized ->
$nocache = $enableCacheValidation && ($secureEntryHelper->shouldDisableCache() || kApiCache::hasExtraFields() || !$secureEntryHelper->isKsWidget() && $secureEntryHelper->hasRules(ContextType::THUMBNAIL));
|
reviewed |
…Naos-14.6.0-PLAT-9256_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l capture access control actions