Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-9607:adding feedback on the whole quiz #8044

Merged
merged 1 commit into from Jan 24, 2019
Merged

PLAT-9607:adding feedback on the whole quiz #8044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions plugins/cue_points/quiz/errors/KalturaQuizErrors.php
View file
Open in desktop
Expand Up @@ -16,6 +16,4 @@ class KalturaQuizErrors extends KalturaErrors
const NO_SUCH_FILE_TYPE = 'NO_SUCH_FILE_TYPE;;Document cannot be provided. No such file type';
const QUIZ_CANNOT_BE_DOWNLOAD = 'QUIZ_CANNOT_BE_DOWNLOAD;;Quiz cannot be download';
const QUIZ_USER_ENTRY_ALREADY_EXISTS = 'QUIZ_USER_ENTRY_ALREADY_EXISTS;ENTRY_ID;A quiz user-entry for the given user-id and entry-id [@ENTRY_ID@] already exists, cannot create duplicate';
const NOT_ENTITLED_TO_INSERT_UPDATE = "NOT_ENTITLED_TO_INSERT_UPDATE;;Current User is not entitled to insert or update the quiz";

}
23 changes: 12 additions & 11 deletions plugins/cue_points/quiz/lib/api/KalturaQuizUserEntry.php
View file
Open in desktop
Expand Up @@ -81,25 +81,26 @@ public function validateForInsert($propertiesToSkip = array())
if(!QuizPlugin::isQuiz($this->entryId))
throw new KalturaAPIException(KalturaQuizErrors::PROVIDED_ENTRY_IS_NOT_A_QUIZ, $this->entryId);
parent::validateForInsert($propertiesToSkip);
if (!$this->validateEntitledKuser())
throw new KalturaAPIException(KalturaQuizErrors::NOT_ENTITLED_TO_INSERT_UPDATE);
$dbEntry = entryPeer::retrieveByPK($this->entryId);
if ($this->feedback != null && !kEntitlementUtils::isEntitledForEditEntry($dbEntry) )
{
KalturaLog::debug('Insert feedback on quiz is allowed only with admin KS or entry owner or co-editor');
throw new KalturaAPIException(KalturaErrors::INVALID_USER_ID);
}
}


public function validateForUpdate($sourceObject, $propertiesToSkip = array())
{
if (!$this->validateEntitledKuser())
throw new KalturaAPIException(KalturaQuizErrors::NOT_ENTITLED_TO_INSERT_UPDATE);
$dbEntry = entryPeer::retrieveByPK($this->entryId);
if ( !kEntitlementUtils::isEntitledForEditEntry($dbEntry) )
{
KalturaLog::debug('Update quiz allowed only with admin KS or entry owner or co-editor');
throw new KalturaAPIException(KalturaErrors::INVALID_USER_ID);
}
return parent::validateForUpdate($sourceObject, $propertiesToSkip);
}

public function validateEntitledKuser()
{
$entry = entryPeer::retrieveByPK($this->entryId);
$kuserId = kCurrentContext::getCurrentKsKuserId();
return $entry->isEntitledKuserEdit($kuserId);
}

protected function validateEntryId()
{
//do nothing - already validating in QuizPlugin::isQuiz
Expand Down