Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10120:adding option to remove synonyms in esearch #8772

Merged
merged 5 commits into from Sep 22, 2019

Conversation

ravitshalem
Copy link
Contributor

No description provided.

@@ -184,6 +184,10 @@ public function init()

$this->getElement('editDeliveryProfiles')->setAttrib('onClick', 'addDeliveryProfile()');

$this->addElement('checkbox', 'ignore_synonym_esearch', array(
'label' => 'Ignore Synonyms in eSearch',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Synonyms should be lower case.
  2. Fix the space after the label

/**
* @var bool
*/
protected $ignoreSynonymsOnPartner;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until now it was called Synonym (single), keep the same name

@ravitshalem ravitshalem merged commit a164058 into Orion-15.8.0 Sep 22, 2019
@ravitshalem ravitshalem deleted the Orion-15.7.0-PLAT-10120 branch September 22, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants