REACH-updating credits #9060
Merged
REACH-updating credits #9060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,4 +52,10 @@ public function hasObjectChanged($sourceObject) | |||
| { | |||
| return false; | |||
| } | |||
|
|
|||
| public function validateForUpdate($sourceObject, $propertiesToSkip = array()) | |||
| { | ||
| return false; | ||
| } | ||
| return get_class($object) == 'kReoccurringVendorCredit'; |
There was a problem hiding this comment.
String matching only with ===
| if (isset($this->fromDate) && isset($this->toDate)) | ||
| { | ||
| if ($this->fromDate > $this->toDate) | ||
| throw new KalturaAPIException(KalturaReachErrors::INVALID_CREDIT_DATES, $this->fromDate, $this->toDate); |
| */ | ||
| public function validateForUpdate($sourceObject, $propertiesToSkip = array()) | ||
| { | ||
| if (!isMatchingCoreClass($sourceObject)) |
There was a problem hiding this comment.
- This code cannot be called;
- The function holds several case , break it to smaller cases.
| /* @var $sourceObject kTimeRangeVendorCredit */ | ||
| if($this->toDate && $this->toDate != $sourceObject->getToDate()) | ||
| if ( method_exists($sourceObject,'getToDate') && $this->fromDate > $sourceObject->getToDate()) |
There was a problem hiding this comment.
Must be used based on object functions , method_exists is bad practice.
| @@ -39,7 +39,7 @@ public function getMapBetweenObjects() | |||
| public function validateForInsert($propertiesToSkip = array()) | |||
| { | |||
| $this->validatePropertyNotNull("fromDate"); | |||
| parent::validateForInsert(array("credit")); | |||
| parent::validateForInsert(array_merge($propertiesToSkip,array("credit"))); | |||
There was a problem hiding this comment.
String without processing - signle qoutes
| return parent::toObject($dbObject, $propsToSkip); | ||
| } | ||
|
|
||
| public function hasObjectChanged($sourceObject) | ||
| { | ||
| if(parent::hasObjectChanged($sourceObject)) | ||
| if (parent::hasObjectChanged($sourceObject)) |
| { | ||
| return false; | ||
| } | ||
| return get_class($object) == 'kUnlimitedVendorCredit'; |
| { | ||
| return false; | ||
| } | ||
| return get_class($object) == 'kVendorCredit'; |
|
reveiwed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MosheMaorKaltura
@yossipapi