SUP-20392:make syndication feed with dynamic playlist work the same as playlist executeFromFilter #9149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… playlist executeFromFilter
… playlist executeFromFilter
… playlist executeFromFilter
… playlist executeFromFilter
|
|
||
| if ($this->dynamicPlaylist) | ||
| { | ||
| return $this->getEntriesCountFromDynamic(); |
There was a problem hiding this comment.
Only this code should be executed if there is a filter
| { | ||
| list($mediaEntryFilterForPlaylist, $playlistService) = self::prepareParameters($entryFilter); | ||
| $entriesFromFilter = $this->getEntriesFromPlaylist($playlistService, $mediaEntryFilterForPlaylist); | ||
| $kalturaEntries = array_merge($kalturaEntries, $entriesFromFilter->toArray()); |
There was a problem hiding this comment.
Keep only the Id's
Use associative array to have the uniq,
| return count($kalturaEntries); | ||
| } | ||
|
|
||
| protected static function getEntryListUnique($kalturaEntries) |
| $this->lastEntryCreatedAt = 0; | ||
| } | ||
|
|
||
| ++$this->returnedEntriesCount; |
There was a problem hiding this comment.
$this->returnedEntriesCount++;
| $this->fetchNextEntriesAccordingToFilter(); | ||
| } | ||
|
|
||
| if (current($this->entriesCurrentPage)) |
There was a problem hiding this comment.
put current into local var
validate local var against !== false;
| if (current($this->entriesCurrentPage)) | ||
| { | ||
| $entry = entryPeer::retrieveByPK(current($this->entriesCurrentPage)->id); | ||
| if($entry && !array_key_exists($entry->getId(), $this->entryIdsHandled)) |
There was a problem hiding this comment.
Check what happen in the current implementation when using multi filters and they return the same object twice.
In any case the return should be false only when no more entries
| $pager = new KalturaPager(); | ||
| $pager->pageSize = $this->syndicationFeed->pageSize; | ||
| } | ||
| if (!$currentFilter) |
There was a problem hiding this comment.
Move up , immediate after getting the value.
| @@ -15,6 +15,8 @@ class KalturaSyndicationFeedRenderer | |||
| const CACHE_EXPIRY = 2592000; // 30 days | |||
|
|
|||
| const PAGE_SIZE_MAX_VALUE = 500; | |||
|
|
|||
| const TOTAL_RESULTS = 200; | |||
There was a problem hiding this comment.
Rename to - DYNAMIC_PLAYLIST_TOTAL...
| $entriesFromFilter = $this->getEntriesFromPlaylist($playlistService, $mediaEntryFilterForPlaylist); | ||
| foreach ($entriesFromFilter as $entry) | ||
| { | ||
| if (!array_key_exists($entry->id,$kalturaEntries)) |
| $currentEntry = current($this->entriesCurrentPage); | ||
| while ($currentEntry !== false) | ||
| { | ||
| $entry = entryPeer::retrieveByPK(current($this->entriesCurrentPage)->id); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.