Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the below deprication errors and warnings #9498

Merged
merged 6 commits into from
Jun 17, 2020

Conversation

jessp01
Copy link

@jessp01 jessp01 commented Jun 14, 2020

PHP Deprecated: Array and string offset access syntax with curly braces is deprecated in /opt/kaltura/app/alpha/apps/kaltura/lib/request/infraRequestUtils.class.php on line 70
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/alpha/apps/kaltura/lib/request/kIpAddressUtils.php on line 198
PHP Deprecated: Array and string offset access syntax with curly braces is deprecated in /opt/kaltura/app/alpha/apps/kaltura/lib/monitor/KalturaMonitorClient.php on line 402
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/plugins/content_distribution/lib/kContentDistributionFlowManager.php on line 1685
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/plugins/content_distribution/lib/kContentDistributionFlowManager.php on line 1693


This change is Reviewable

PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /opt/kaltura/app/alpha/apps/kaltura/lib/request/infraRequestUtils.class.php on line 70
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/alpha/apps/kaltura/lib/request/kIpAddressUtils.php on line 198
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /opt/kaltura/app/alpha/apps/kaltura/lib/monitor/KalturaMonitorClient.php on line 402
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/plugins/content_distribution/lib/kContentDistributionFlowManager.php on line 1685
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/plugins/content_distribution/lib/kContentDistributionFlowManager.php on line 1693
@erankor
Copy link
Contributor

erankor commented Jun 14, 2020

Looks good to me

@jessp01 jessp01 changed the base branch from Propus-16.4.0 to Propus-16.5.0 June 15, 2020 08:57
@yossipapi
Copy link
Collaborator

Looks ok.

Jess portnoy added 4 commits June 15, 2020 13:27
…d you mean to use "continue 2"? in /opt/kaltura/app/infra/cdl/kdl/KDLFlavor.php on line 1971

PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/infra/cdl/kdl/KDLOperatorBase.php on line 89
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/vendor/ZendFramework/library/Zend/Form.php on line 1117
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /opt/kaltura/app/vendor/ZendFramework/library/Zend/Form.php on line 1523
PHP Notice:  compact(): Undefined variable: extras in /opt/kaltura/app/vendor/ZendFramework/library/Zend/View/Helper/HeadLink.php on line 371
…pt/kaltura/app/alpha/apps/kaltura/lib/request/infraRequestUtils.class.php on line 480
@jessp01
Copy link
Author

jessp01 commented Jun 16, 2020

So can I merge this?

@MosheMaorKaltura
Copy link
Contributor

Reviewed

@jessp01 jessp01 merged commit 37878f1 into Propus-16.5.0 Jun 17, 2020
@jessp01 jessp01 changed the title Fixes the below erros Fixes the below deprication errors and warnings Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants