Forbid unsafe code #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `cargo geiger` happy.
itudoben
reviewed
Jun 11, 2021
| @@ -165,6 +165,8 @@ | |||
| //! buffer or `Reader` (thanks to the change of `Value::Undefined` | |||
| //! and `Value::Ascii` described above). | |||
|
|
|||
| #![forbid(unsafe_code)] | |||
There was a problem hiding this comment.
Any reason why unsafe code should be forbidden?
From geiger crate author, it looks like it's up to the user to decide.
It is, however, the opinion of the author of this project that libraries choosing to abstain from unsafe Rust usage when possible should be promoted.
There was a problem hiding this comment.
If you don't use unsafe code, then you should forbid it, as it makes cargo geiger's job easier, it makes it clearer that you're not using unsafe anywhere, and there are some things that are unsafe but you don't put an unsafe keyword around, and forbid(unsafe_code) forbids those.
Of course, if you do need unsafe code for a good reason, you can't do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
cargo geigerhappy.