Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preloaded library for openssl v1.1 process shared locking #1927

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Preloaded library for openssl v1.1 process shared locking #1927

merged 3 commits into from
Apr 15, 2019

Conversation

miconda
Copy link
Member

@miconda miconda commented Apr 12, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Preloaded library to make libssl 1.1 use pthread locks with process shared option.

rfuchs and others added 3 commits April 11, 2019 14:29
@rfuchs
tls: add preloaded library to force process-shared locks
efdc141 
This is a hacky workaround for OpenSSL >= 1.1 which uses internal
locking and doesn't support locks in memory shared across multiple
processes.
@miconda
tls: added a readme for openssl_mutex_shared
4c0aa78
@miconda
tls: docs - short note about libssl 1.1.x and openssl_mutex_shared
ee32a6e
@miconda miconda merged commit ef09ff9 into master Apr 15, 2019
@miconda miconda deleted the rfuchs/openssl-locking-fix branch April 15, 2019 06:38
sergey-safarov
sergey-safarov reviewed Apr 15, 2019
View reviewed changes
src/modules/tls/utils/openssl_mutex_shared/README.md
If using systemd, add to service file:

```
Environment='LD_PRELOAD=/usr/local/lib64/kamailio/openssl_mutex_shared/openssl_mutex_shared.so'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel
Is need to do same action when kamailio packaged and located at /usr/sbin/kamailio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-safarov sergey-safarov sergey-safarov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miconda @sergey-safarov @rfuchs