Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/kemi: add script to generate mock api for kemi python testing #2350

Merged
merged 2 commits into from Jun 8, 2020

Conversation

tsearle
Copy link
Member

@tsearle tsearle commented Jun 8, 2020

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request introduces 1 alert when merging 8645d5e into 49e80db - view on LGTM.com

new alerts:

  • 1 for Unused import

@henningw henningw merged commit 2d2594d into master Jun 8, 2020
@henningw
Copy link
Contributor

henningw commented Jun 8, 2020

Thank you!

@miconda
Copy link
Member

miconda commented Jun 8, 2020

@tsearle - do not forget to use the component name in the commit message, the second commit in the PR does not have the right format. The alternative is to squash all the commits in one before merging.

@miconda miconda deleted the python_mock branch June 8, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants