lcr: source port check for from_any_gw() and from_gw(). #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple change, which allows to check, if a coming request matches not only by an IP address and a transport protocol, but also using the source port of a request. Improvements are done for the following functions of the lcr module: - from_any_gw() - from_gw() Back compatibility provided, hence it does not affect already existing behavior.
|
This pull request introduces 2 alerts when merging 14e6fc8 into 5ad81a4 - view on LGTM.com new alerts:
|
|
Thanks for the pull request. There are two alerts mentioned above (check for < 0 for an unsigned int is obviously not necessary), please have a look to it. After fixing you can push to the branch, no need for a new pull request. |
Remove unneeded check for 'src_port' in: - ki_from_any_gw_addr() - ki_from_gw_addr() Which makes no sense because 'src_port' is of type 'unsigned int', and the check concerns whether it's less than 0 or not.
|
I haven't tested the new feature, but from backwards compatibility point of view, the implementation looks good to me. Thus I have nothing against the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
A simple change, which allows to check, if a coming request matches
not only by an IP address and a transport protocol,
but also using the source port of a request.
Improvements are done for the following functions of the lcr module:
Back compatibility provided, hence it does not affect already existing behavior.