dialog keep-alive only for own records

[Riccardo-78]

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue dialog keep-alive only for own records #3018

Description

Skip keepalive check if dialog is not local, do the same in case of dialog timeout

[miconda]

Thanks for the PR! I would suggest to add a module parameter to control this behaviour, to avoid looking up the socket every time. Also, there are cases when a restart is done to change the ip addresses and if the Routes were with FQDN, it is wanted to continue processing dialogs even if the old ip is not found.

[lgtm-com]

This pull request introduces 2 alerts when merging eb80bcb into b3314c8 - view on LGTM.com

new alerts:

• 2 for Expression has no effect

[Riccardo-78]

it makes sense, added new parameter (ignore_non_local_dlg) to control this behaviour

[miconda]

Thanks!

I will merge it soon, but then I will rename the new parameter to something like dlg_filter_mode and behave on a flags-like value, because it could be useful to reuse it for other purposes, like having a filter mode where dialogs are not loaded from database if they don't have local socket.