nats: add KEMI publish function and event_callback param #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. @seven1240 to generate locally - see here http://www.kamailio.org/wiki/devel/module-docbook-readme |
|
I updated the doc and squashed into one commit. |
|
@eschmidbauer: any comments on this PR? |
src/modules/nats/nats_mod.c
Outdated
| @@ -73,39 +79,36 @@ static void onMsg( | |||
| natsConnection *nc, natsSubscription *sub, natsMsg *msg, void *closure) | |||
| { | |||
| nats_on_message_ptr on_message = (nats_on_message_ptr)closure; | |||
| char *s = (char *)natsMsg_GetSubject(msg); | |||
| // char *s = (char *)natsMsg_GetSubject(msg); | |||
There was a problem hiding this comment.
can we remove this comment?
| } | ||
| } else { | ||
| run_top_route(event_rt.rlist[rt], fmsg, 0); | ||
| } |
There was a problem hiding this comment.
if (rt < 0 && keng) {
if (sr_kemi_route(keng, fmsg, EVENT_ROUTE, &nats_event_callback, evname) < 0) {
LM_ERR("error running event route kemi callback\n");
}
return 0;
}
run_top_route(event_rt.rlist[rt], fmsg, 0);
return 0;
src/modules/nats/nats_mod.h
Outdated
| @@ -30,6 +30,7 @@ | |||
| #include "../json/api.h" | |||
| #include "../../core/cfg/cfg_struct.h" | |||
| #include "../../core/fmsg.h" | |||
| // #include "../../core/str.h" | |||
There was a problem hiding this comment.
can we remove this commented code ?
eschmidbauer
approved these changes
Jun 21, 2022
|
Thanks. updated as suggested and squashed and rebased to the latest master. |
|
I see @eschmidbauer approved the changes, therefore I merge it. |
miconda
pushed a commit
that referenced
this pull request
Jul 4, 2022
(cherry picked from commit 25d42b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
event_callbackKEMI param like in other modulesKSR.nats.publishI can fix module doc if it looks good. How to generate docs locally btw?