cnxcc: make cnxcc locks re-entrant #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caruizdiaz
added a commit
that referenced
this pull request
Nov 15, 2015
cnxcc: make cnxcc locks re-entrant
|
Thank you for the patch! I've been having no time to fix the issues that has been reported for cnxcc, so this one comes in a perfect time, thanks! |
|
You're welcome! |
|
Shouldn't the patch be backported to 4.3, since the issue is present there too? |
|
I had it in mind to ask in the morning, when I did some backports, but got caught in other projects. Go ahead and do it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cnxcc call termination is not working anymore since commit 265dc95. That commit introduced the call to DLGCB_TERMINATED callbacks for the locally generated BYE, which leads to a deadlock in cnxcc when it tries to end the calls because the credit (money or time) is exhausted.
This patch introduces a new structure cnxcc_lock which implements re-entrant locks.
As a side question I'm wondering if, since other modules need re-entrant locks, this structure should be defined in lock_ops.h like the other kamailio's locks.