Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: exit with failure code if a child dies #403

Merged
merged 1 commit into from Nov 19, 2015

Conversation

camilleoudot
Copy link
Contributor

I made this patch to ensure kamailio exits with an unclean status if it stops due to a child exits. This allows systemd's unit Restart=on-failure parameter to actually automatically restart kamailio, in a segfault or any other signal-throwing situation.

The side effect is that it would trigger a kamailio restart if one of the children is stopped with a TERM signal, but I considered here that the only clean way to stop kamailio is to send a signal to the main attendant process, and not to a child.

@miconda
Copy link
Member

miconda commented Nov 19, 2015

Thanks! It can be merged.

camilleoudot added a commit that referenced this pull request Nov 19, 2015
core: exit with failure code if a child dies
@camilleoudot camilleoudot merged commit a5b5091 into master Nov 19, 2015
@camilleoudot camilleoudot deleted the child_stop_fail_status branch November 19, 2015 11:26
@miconda
Copy link
Member

miconda commented Nov 19, 2015

Btw, probably has to be backported as well ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants