Skip to content
This repository has been archived by the owner on Dec 21, 2019. It is now read-only.

Change mout dependency to be less restrictive #40

Closed
wants to merge 1 commit into from

Conversation

mpj
Copy link

@mpj mpj commented Sep 18, 2014

Very helpful when deduping.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c90866f on mpj:patch-1 into f0fe4c7 on kamicane:master.

@jdalton
Copy link

jdalton commented Sep 18, 2014

Mout is still not v1.0 and introduces breaking changes from release to release. If anything, because it's pre-1.0 you should be more restrictive.

@kentaromiura
Copy link
Contributor

I agree with @jdalton, a "compatible with 0.9" is not a good idea for the reason he has state, also because the "compatible with" is only working on node post >= 0.10 and iirc prime still works fine on previous version of node.
This change will make prime incompatible with 0.8 for no apparent reason.

@GCheung55
Copy link
Contributor

prime is 0.4.x right now. I think it can afford to have breaking changes. That said, it can be more restrictive and test against moutjs@0.10 before updating.

This change will make it incompatible with node.js@0.8 because of the semver ^ correct?

@kentaromiura
Copy link
Contributor

Yep

@mpj mpj closed this Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants