-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning for set-output #2370
Conversation
|
plz rebase, also deprecated set output was refactored in this PR #2358 |
@B2o5T conflicts resolved. Note that #2358 only fixes deprecation warnings within https://github.com/kamilkisiela/graphql-inspector, not for all of the repos that use the graphql-inspector GitHub Action. Those should be resolved by cutting a release. |
@B2o5T resolved conflicts again. Should I remove the changes to |
Confirmed the 3.4.11 release addresses the issue with set-ouput. I'll open a separate PR for the typo fixes here |
@nathanchapman This is still relevant? |
Not anymore, the necessary change (regenerating As for the issue #2196, that won't be fully solved until another release is created containing the changes from #2221 |
Just noticed that another release was created ~6 hours ago, going to try to verify the fix with that new version |
Confirmed the fix, thanks @TuvalSimha! |
@nathanchapman Great news! thank you! |
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
Addresses second half of GitHub Actions Deprecation notices re:
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#patching-your-actions-and-workflows
This was half-fixed by a renovate update PR (#2301), which upgraded
@actions/core
to1.10.0
. Now,action/index.js
just needs to be rebuilt and released.Fixes #2196
The other deprecation notice is addressed by #2221 (upgrade from Node12 to Node16)
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-inspector/...
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...