Adding paginated? helper to active record extensions and page scope methods #1118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Purpose
Adding a
paginated?
helper to PageScopeMethods and AR extensions.Context
Lately I found myself implementing a
See All
option in a few pages. As expected I had to find a way to conditionally renderpaginate
section leading to conditions on views asrelation.respond_to?(:total_pages)
orrelation.limit_value.present?
.That was the moment when the
paginated?
helper came to my mind, a simple and clean method to achieve this check.Changes
paginated?
with default value false to AR relations to have it available even if pagination method wasn't calledpaginated?
on PageScopeMethods relying onlimit_value
(this way we ensure the helper being true just when the pagination method is called and include support to possibleunscope
calls too)On a separated note: contributions section on README should be updated, current lines described there to run specs are relying on removed
gemfiles/*