Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost this context in resize event handler #14

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

vyobukhov
Copy link
Contributor

@vyobukhov vyobukhov commented Jun 29, 2021

Resize function has a broken this context right now. It was not an issue in previous versions because stdout was used directly

this.width = stdout.columns;
this.height = stdout.rows - 1;

And now, when this.stream is used, library crashes on resize

this.width = this.stream.columns;
this.height = this.stream.rows;

Copy link
Owner

@kamiyo kamiyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Sorry I overlooked this.

@kamiyo kamiyo merged commit 7544e01 into kamiyo:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants