-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kamon-logback: support of logback-classic 1.4.3 #1212
Comments
Need to change the configuration (disable MDC context) kamon.instrumentation.logback.mdc.copy.enabled = false to work with logback-classic 1.4.3. The recent logback commit - qos-ch/logback@7e3e2ae - updated the method getCopyOfContextMap() to call getPropertyMap(). Cheers |
so kamon will still be using logback 1.2.x and i need to wait for the newest logback-classic update right? |
1.4.4 seems not to work either
|
If you don't use the MDC context in the log, you can update the configuration kamon.instrumentation.logback.mdc.copy.enabled = false to use logback 1.4.3+. Cheers |
Same problem here |
@e2000y i dont understand you. the issue is about having both the newest version of logback and kamon logback with its ALL FEATURES. |
Yes. Advize to disable this feature is non sense |
Hey @bwiercinski @Dichotomia, could you please share a bit more information to reproduce? I tried to run on a simple app with Kamon 2.5.9 and logback 1.4.4 and couldn't see any issue. I'm guessing there has to be something else on your classpath or logback configuration that triggers the issue 😕 |
I have a log like that `OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
1 error |
Play 2.8.18 |
Thanks @Dichotomia! Turns out I didn't have the instrumentation running on my test app, that's why it didn't blow up 🤦 I'm looking into this right now. Will update soon! |
Thanks! Good news. Waiting for the new release 😉 |
…ws, fixes kamon-io#1212 (kamon-io#1220)" This reverts commit 5cf9653.
kamon-logback
module seems not to work with newest version oflogback
(1.4.3).when starting an application i get following error:
cheers
The text was updated successfully, but these errors were encountered: