reorganize the logback instrumentation to avoid stack overflows, fixes #1212 #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvollmar
added a commit
to nvollmar/Kamon
that referenced
this pull request
Jan 18, 2023
…ws, fixes kamon-io#1212 (kamon-io#1220)" This reverts commit 5cf9653.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an interceptor where we end up with calls to the super class, we are using an advice that overrides map returned by
ch.qos.logback.classic.util.LogbackMDCAdapter#getPropertyMap.This makes the same instrumentation work with logback 1.2.x, 1.3.x, and 1.4.x.