Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoTimestamp and NanoInterval as Case Classes #376

Closed
elm- opened this issue Jul 27, 2016 · 2 comments
Closed

NanoTimestamp and NanoInterval as Case Classes #376

elm- opened this issue Jul 27, 2016 · 2 comments
Milestone
0.6.3

Comments

@elm-
Copy link

elm- commented Jul 27, 2016

Is there any specific reason why NanoTimestamp and NanoInterval are not implemented as case classes and if not, would there be anything preventing it?

I noticed it when writing some protocols for serialization, I had to do custom protocols for these two when serializing TraceInfo and Segment.
@dpsoft
Copy link
Contributor

dpsoft commented Jul 27, 2016

@ivantopo ping!!!

@dpsoft
Copy link
Contributor

dpsoft commented Jul 29, 2016 •
edited
Loading

@elm- I see your point. I think is a really easy change and the users that want serialize TraceInfo and SegmentInfo will avoid a headache. ;)

@dpsoft dpsoft closed this as completed in 770cb36 Jul 31, 2016
@dpsoft dpsoft added this to the 0.6.3 milestone Sep 30, 2016
dpsoft added a commit that referenced this issue Dec 4, 2016
@dpsoft
= core: NanoTimestamp and NanoInterval as case classes and closes #376
cf140b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.3
Development

No branches or pull requests
2 participants
@dpsoft @elm-