NanoTimestamp and NanoInterval as Case Classes #376

Closed
elm- opened this Issue Jul 27, 2016 · 2 comments

Projects

None yet

2 participants

@elm-
elm- commented Jul 27, 2016

Is there any specific reason why NanoTimestamp and NanoInterval are not implemented as case classes and if not, would there be anything preventing it?

I noticed it when writing some protocols for serialization, I had to do custom protocols for these two when serializing TraceInfo and Segment.

@dpsoft
Contributor
dpsoft commented Jul 27, 2016

@ivantopo ping!!!

@dpsoft
Contributor
dpsoft commented Jul 29, 2016 edited

@elm- I see your point. I think is a really easy change and the users that want serialize TraceInfo and SegmentInfo will avoid a headache. ;)

@dpsoft dpsoft closed this in 770cb36 Jul 31, 2016
@dpsoft dpsoft added this to the 0.6.3 milestone Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment