Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kanela to 1.0.11 #1030

Merged
merged 5 commits into from
Jun 4, 2021
Merged

Bump Kanela to 1.0.11 #1030

merged 5 commits into from
Jun 4, 2021

Conversation

dpsoft
Copy link
Contributor

@dpsoft dpsoft commented May 29, 2021

Copy link
Contributor

@SimunKaracic SimunKaracic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a kanela agent version in build.sbt:

Kamon/build.sbt

Line 684 in 36226d0

kanelaAgentVersion := "1.0.9",

Update that too please, or if you feel like it dig around and try to figure out why it's declared twice.

Other than that, great PR, thanks for the contribution! 🎉

@dpsoft
Copy link
Contributor Author

dpsoft commented Jun 2, 2021

@SimunKaracic please don't merge. the play tests are not running.

@dpsoft
Copy link
Contributor Author

dpsoft commented Jun 2, 2021

@SimunKaracic this is the error: [main] ERROR 2021-06-02 09:44:19 Logger : Error => scala.util.Failure with message Illegal parameter name of final scala.Function0 default for public java.lang.Object scala.util.Failure.getOrElse(scala.Function0). Class loader: sun.misc.Launcher$AppClassLoader@18b4aac2: java.lang.IllegalStateException: Illegal parameter name of final scala.Function0 default for public java.lang.Object scala.util.Failure.getOrElse(scala.Function0)

@SimunKaracic
Copy link
Contributor

I'm not sure what to do with that, do you think it's caused by something other than bumping kanela to the new version?

@dpsoft
Copy link
Contributor Author

dpsoft commented Jun 2, 2021

I found the issue, I will fix and make a new minor kanela release.

@dpsoft dpsoft changed the title Bump Kanela to 1.0.10 Bump Kanela to 1.0.11 Jun 4, 2021
@dpsoft
Copy link
Contributor Author

dpsoft commented Jun 4, 2021

@SimunKaracic done!

@SimunKaracic
Copy link
Contributor

Great job @dpsoft!

@SimunKaracic SimunKaracic merged commit 5c51232 into master Jun 4, 2021
@dpsoft dpsoft deleted the bump-kanela-to-1.0.10 branch June 4, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants