Scale #294
Merged
Scale #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,7 @@ object Counter { | |||
| trait Snapshot extends InstrumentSnapshot { | |||
| def count: Long | |||
| def merge(that: InstrumentSnapshot, context: CollectionContext): Counter.Snapshot | |||
| def scale(from: UnitOfMeasurement, to: UnitOfMeasurement): Counter.Snapshot | |||
There was a problem hiding this comment.
Not sure if this should be part of InstrumentSnapshot... I clearly see histograms and gauges being scaled depending on their units, but min-max-counters and regular counters shouldn't be scaled.. wdyt?
There was a problem hiding this comment.
can't one have, say, regular counters with Memory or Time units?
|
hey @jozic! Again, thanks for such a great job! There are just a few things to settle but you got the right approach :).. I'm sorry that I have been a bit away (well, more than a bit to be honest), but let's get this done! |
|
no problem @ivantopo :) |
|
@ivantopo ping |
dpsoft
added a commit
that referenced
this pull request
Dec 24, 2015
dpsoft
added a commit
that referenced
this pull request
Dec 4, 2016
ivantopo
pushed a commit
that referenced
this pull request
Mar 9, 2020
ivantopo
pushed a commit
that referenced
this pull request
Mar 29, 2020
ivantopo
pushed a commit
that referenced
this pull request
Mar 29, 2020
ivantopo
pushed a commit
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #288 and fixes #111
@ivantopo @dpsoft please review
if this looks okay, i will send another pr to kamon-io/kamon.io to update docs for statsd and datadog