Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in "normalize" strategy - add replace(":", "-") after replace(": ", "-") to cover the remotely deployed actors case #325

Merged
merged 2 commits into from Mar 29, 2016
Merged

in "normalize" strategy - add replace(":", "-") after replace(": ", "-") to cover the remotely deployed actors case #325

merged 2 commits into from Mar 29, 2016

Commits on Mar 20, 2016

  1. in "normalize" strategy - replace ":" with "-", instead of ": " with "-" 

    Remote actors paths look like
akka.tcp://ActorSystemName@Slavehost1:2551/remote/akka.tcp/ActorSystemName@Masterhost:2551/user/master/myRouter/c10

Before the change the remote actor's metrics didn't get through because
the ':' after the Masterhost and everything that followed it was cut off.
A metric name in grafana would look like
ActorSystemName.slavehost1.akka-actor.ActorSystemName_remote_akka_tcp_ActorSystemNameMasterhostIP,
now it looks like
ActorSystemName.slavehost1.akka-actor.ActorSystemName_remote_akka_tcp_ActorSystemNameMasterhostIP-2551_user_master_myRouter_c4.errors
    Shohet committed Mar 20, 2016
    Copy the full SHA
    34cd2a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2016

  1. revert to ": " to cover the "trace", "POST: /kamon/example" case, but… 

    … add replace(":", "-") afterwards to cover the remotely deployed actors case too
    Shohet committed Mar 21, 2016
    Copy the full SHA
    779694b View commit details
    Browse the repository at this point in the history