influxdb: don't send zeroes when histogram is empty #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior: When a histogram has no records, Kamon sends zeroes. It's not possible to differenciate the absence of value from a zero value. New behavior: Kamon doesn't send data for empty histograms.
|
Meh, CLAs are not fun! But I really love Kamon so it's the least I can do to thank you guys. Signed. By the way I'll be deploying this patch to https://lichess.org in 12h. I'll let you know if it goes wrong. |
|
@ornicar done!!! |
ornicar
added a commit
to ornicar/Kamon
that referenced
this pull request
Dec 3, 2016
* 'master' of https://github.com/kamon-io/Kamon: influxdb: don't send zeroes when histogram is empty (kamon-io#414)
ivantopo
pushed a commit
that referenced
this pull request
Mar 31, 2020
Previous behavior: When a histogram has no records, Kamon sends zeroes. It's not possible to differenciate the absence of value from a zero value. New behavior: Kamon doesn't send data for empty histograms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior: When a histogram has no records, Kamon sends zeroes.
It's not possible to differenciate between the absence of value, and a value of zero.
New behavior: Kamon doesn't send data for empty histograms.