influxdb: don't send zeroes when histogram is empty #414

Merged
merged 1 commit into from Dec 2, 2016

Projects

None yet

2 participants

@ornicar
ornicar commented Dec 2, 2016

Previous behavior: When a histogram has no records, Kamon sends zeroes.
It's not possible to differenciate between the absence of value, and a value of zero.

New behavior: Kamon doesn't send data for empty histograms.

@ornicar ornicar influxdb: don't send zeroes when histogram is empty
Previous behavior: When a histogram has no records, Kamon sends zeroes.
It's not possible to differenciate the absence of value from a zero
value.

New behavior: Kamon doesn't send data for empty histograms.
0f420d2
@dpsoft dpsoft added this to the 0.6.4 milestone Dec 2, 2016
@dpsoft
Contributor
dpsoft commented Dec 2, 2016

@ornicar thanks for proposing this PR, please sign our CLA we are good to go!

@ornicar
ornicar commented Dec 2, 2016

Meh, CLAs are not fun!

But I really love Kamon so it's the least I can do to thank you guys. Signed.

By the way I'll be deploying this patch to https://lichess.org in 12h. I'll let you know if it goes wrong.

@dpsoft dpsoft merged commit 2ce7b7d into kamon-io:master Dec 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dpsoft
Contributor
dpsoft commented Dec 2, 2016

@ornicar done!!!

@ornicar ornicar added a commit to ornicar/Kamon that referenced this pull request Dec 3, 2016
@ornicar ornicar Merge branch 'master' of https://github.com/kamon-io/Kamon into lila
* 'master' of https://github.com/kamon-io/Kamon:
  influxdb: don't send zeroes when histogram is empty (#414)
1ae68c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment