restart the trace reporters ticker when the traceTickInterval changes #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution: I would close this PR for potential lack of understanding, but wondering if the change on line 203 is correct. |
briantopping
changed the title
|
Hey @briantopping, thanks for the PR! the change in line 203 definitely has to come in, but the warning is not necessary. Reconfiguring Kamon doesn't necessarily mean that reporters should be present or not and there is already a warning log when loading reporters from configuration and nothing is in the Could you please re-purpose the PR (commit message, PR title and so on) towards only fixing the issue on line 203? Thanks! |
|
Thanks @briantopping 👍 I'm sorry I didn't see that you actually updated the PR before, shipped v1.0.1 a few hours ago.. this will make it to 1.0.2 |
ivantopo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding a warning about nothing to collect, I think I noticed a bug with the comparison about
traceTickInterval.The warning is good when people don't even know if Kamon is loading. They'll at least see something in their logs this way.