Configurable operation name mappings for http client instrumentation #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacarvalho91
force-pushed
the
769-http-client-operation-name-mappings
branch
3 times, most recently
from
7a14929
to
6bb9b9b
Compare
ivantopo
requested changes
May 18, 2020
There was a problem hiding this comment.
Hey @lacarvalho91, this is awesome! I have just a minor comment about where to place a function but other than that this looks really nice 🎉
...n-instrumentation-common/src/main/scala/kamon/instrumentation/http/HttpInstrumentation.scala
Outdated
Show resolved
Hide resolved
|
thanks for the review @ivantopo! I have addressed your comment 🙂 |
lacarvalho91
force-pushed
the
769-http-client-operation-name-mappings
branch
2 times, most recently
from
9d25f6a
to
da53f7d
Compare
lacarvalho91
force-pushed
the
769-http-client-operation-name-mappings
branch
from
9c40fe1
to
be5959d
Compare
lacarvalho91
commented
May 24, 2020
...tion/kamon-jdbc/src/test/scala/kamon/instrumentation/jdbc/StatementInstrumentationSpec.scala
Show resolved
Hide resolved
|
@ivantopo anymore thoughts on this? |
|
Thanks a lot @lacarvalho91! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #769
I can't seem to get the project to build locally to be able to run the tests. so I'm gonna have to leave that to Travis.
Please let me know if I've missed anything.