Matching the Stale Period of PrometheusPushgatewayReporter accumulator to the one of PrometheusReporter accumulator #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to the one of PrometheusReporter accumulator
|
@ivantopo maybe? We would like to use kamon in our new project but are unable to to so if prometheus push does not work. |
|
@SimunKaracic maybe? Anything we can to to get this in? |
|
I'm not sure why we were hesitant to merge this, it looks like a good, sensible change. Thanks for the contribution and the patience :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really not sure if this was intended behaviour or not but when PrometheusPushgatewayReporter is instantiated it creates an instance of PeriodSnapshot accumulator using the default Stale Period of 365 days (as opposed to PrometheusReporter which creates it with a period of 5 years). As a result when using the PGWReporter all of our metrics get cleaned as stale and are not sent out.
Note I haven't signed the CLA yet as I am not sure if this was intended behaviour or not.
Perhaps there's something I missed in the config that would resolve this issue?