Akka typed actor tag and auto-grouping changes #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantopo
requested changes
Nov 21, 2020
instrumentation/kamon-akka/src/common/scala/kamon/instrumentation/akka/AkkaMetrics.scala
Show resolved
Hide resolved
SimunKaracic
force-pushed
the
akka-typed-instrumentation
branch
from
7b19534
to
bf5b1e3
Compare
Actor class name tag is removed when the actor is typed. Operation name is now only 'operation(MessageClass)', where before it was 'operation(ActorClass, MessageClass)'
This must be done becase we can no longer obtain the actor class name consistently, since typed actors are converted to ActorAdapters. If we don't disable autogrouping, all typed actors on the same level are placed in the same group
SimunKaracic
force-pushed
the
akka-typed-instrumentation
branch
from
bf5b1e3
to
e0879d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes based on the fact that typed actors get converted to ActorAdapter class, rendering some tags and existing behaviour pointless.
Changes
ActorAdapter)