Upgraded to http4s 0.20.0 + Fixed flaky failing test. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcmteixeira
commented
Apr 25, 2019
| GeneralMetrics().activeRequests.distribution().min shouldBe 0L | ||
| } | ||
|
|
||
| reporter.clear() |
There was a problem hiding this comment.
as far as I could tell it doesn't seem to be used in this test at all!
cmcmteixeira
commented
Apr 25, 2019
|
|
||
| val test = IO { | ||
| eventually(timeout(5 seconds)) { |
There was a problem hiding this comment.
Due to the way the test is setup, requests *> test the test is only run after all requests have completed therefore there's no need to use eventually.
cmcmteixeira
commented
Apr 25, 2019
|
|
||
| reporter.clear() | ||
|
|
||
| GeneralMetrics().activeRequests.distribution().max should be > 1L |
There was a problem hiding this comment.
Initial constraint was that it had to be =10 but it would some times fail
Bigger than 1 seems reasonable as it proves that one or more requests were active at the same time!
|
@cmcmteixeira done! Thanks for proposing this PR |
stsatlantis
pushed a commit
to stsatlantis/kamon-http4s
that referenced
this pull request
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.