Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 support kamon 2.5.7 #50

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

vaslabs
Copy link
Contributor

@vaslabs vaslabs commented Aug 26, 2022

Summary

Notes on http4s

  • http4s 0.22 is EOL but it's not my place to remove the module but there are no scala 3 builds for it.
  • http4s 1.0 is on milestone version and has scala 3 builds - updated to the latest milestone
  • http4s 0.23 is the stable version

Test changes

Kamon testkit

Since kamon 2.3 release a change in the tests (and the way kamon is initialised in core) were causing kamon-http4s tests to yield failures, however testkit functionality was provided to initialise kamon - necessary changes were made here

Scalatest

Scalatest was also updated since the umbrella project has a scalatest version that has no scala 3 builds.

Scala 3 compiler

  • Added the proper scala 3 flag for generating java 8 bytecode
  • Added scala 3 migration flag (not actually needed but to keep it consistent with the kamon project just for future consideration)

Suggestions

  • Probably some of these compiler + version updates can go to the umbrella project.
  • Can probably drop http4s 0.22 as it's EOL

README update

Please let me know if you want me to update the README. Assuming we know the future version (e.g. 2.3.0) we can do

kamon kamon-http4s status jdk scala http4s
2.5.7+ 2.3.0 stable 8+ 2.12, 2.13 0.22.x
2.5.7+ 2.3.0 stable 8+ 2.12, 2.13, 3.x 0.23.x
2.2.7+ 2.3.0 stable 8+ 2.12, 2.13, 3.x 1.0.x

Support scala 3 for http4s 0.23 and 1.0
@vaslabs vaslabs force-pushed the scala-3-support-kamon-2.5.7 branch from 992dcb6 to 231ea2c Compare August 26, 2022 12:12
@ivantopo
Copy link
Contributor

ivantopo commented Oct 5, 2022

Hey @vaslabs, thanks for bringing this up!

Copy link
Contributor Author

@vaslabs vaslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file (.bsp/sbt.json) should probably be removed from version control

@Ali-Mahmood
Copy link

@vaslabs are we going to merge this one day?

@ivantopo ivantopo mentioned this pull request May 16, 2023
@ivantopo ivantopo merged commit a56a915 into kamon-io:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants