- Issue #8: Add artifactFilter to prevent inadvertently using the sou… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottweaver
commented
Nov 16, 2016
scottweaver
commented
- Issue Incorrect aspectjweaver jar used for 'javaagent:' if aspectjweaver-1.8.6-sources.jar is present. #8: Add artifactFilter to prevent inadvertently using the source jar instead of the binary jar for aspectj weaver.
- Bump SBT version to 0.13.13
- Issue Incorrect aspectjweaver jar used for 'javaagent:' if aspectjweaver-1.8.6-sources.jar is present. #8: Change settings in ping pong example to demonstrate and reproduce the source jar issue.
… the source jar instead of the binary jar for aspectj weaver. - Bump SBT version to 0.13.13 - Issue kamon-io#8: Change settings in ping pong example to demonstrate and reproduce the source jar issue.
|
@scottweaver awesome!!! what about to update the |
|
Sure, I can do that. I can also look at cleaning up some of the SBT deprecation warnings if you are cool with that? |
|
@scottweaver yes please!. |
- Remove as many SBT deprecation warnings as possible. - Bump AspectJ to 1.8.9
|
That should be most of the compile warnings in AspectJRunner. |
|
@scottweaver awesome man!!! thanks for proposing this PR. I will make a new release at night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.