Remote control #90
Merged
Remote control #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most notably google urls contain a '?url=' when on the search page
|
Awesome contribution. Thanks 👍 |
Merged
renatobezerra
pushed a commit
to renatobezerra/pennywise
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds an http server inside Pennywise, listening for requests with a
url=query parameter, to allow urls to be requested from other sources.I've written a browser extension here (not yet published) to take advantage of this, but I don't see this as the only use case.
The port was chosen to be fixed at
6280because it's Pennywise's phone number. It also doesn't appear on the wikipedia entry for TCP and UDP port numbers.