Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang: Fix nested list/vector/map equality #162

Merged
merged 2 commits into from
Feb 1, 2016

Conversation

dubek
Copy link
Collaborator

@dubek dubek commented Feb 1, 2016

As described in #123 .

I also found another test case not covered, so I added it to the soft-tests in step9. We might see other impls soft-fail there if the map values weren't compared properly.

@kanaka
Copy link
Owner

kanaka commented Feb 1, 2016

Good catch.

BTW, I've been using the following shell command (using the travis ruby gem command) to pull down logs locally so that I can grep/view them more easily:

BUILD=256; for x in $(seq 1 45); do echo ${BUILD}/${x}; mkdir -p logs/${BUILD}; travis logs ${BUILD}.${x} > logs/${BUILD}/${x}; done

Sometimes the logs take a while to be available for the command line tool (even after they complete and are available in the web interface). It's doesn't always happen, but when it does it's usually 5-10 minutes after completion before they are available from the command line.

Looks like factor is the only other implementation that fails these tests (and the nested tests).

kanaka added a commit that referenced this pull request Feb 1, 2016
erlang: Fix nested list/vector/map equality
@kanaka kanaka merged commit cbd961b into kanaka:master Feb 1, 2016
@dubek dubek deleted the erlang-fix-nested-equality branch February 1, 2016 17:34
@dubek
Copy link
Collaborator Author

dubek commented Feb 1, 2016

Actually elixir soft-fails this new step9 test. @ekmartin - want to try and tackle it following your #155 fix?

@ekmartin
Copy link
Contributor

ekmartin commented Feb 1, 2016

#163, @dubek. Might have to refactor my equals implementation some day, there might be more cases like these that'll cause it to fail in regards of vectors/lists.

@dubek
Copy link
Collaborator Author

dubek commented Feb 1, 2016

Thanks @ekmartin .

I have a fix for Factor which passes step4 but still soft-fails on the new step9 test, so I'll work on that later.

micfan pushed a commit to micfan/make-a-lisp that referenced this pull request Nov 8, 2018
erlang: Fix nested list/vector/map equality
luelista pushed a commit to luelista/mal that referenced this pull request Mar 10, 2024
erlang: Fix nested list/vector/map equality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants