Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested equality tests and then make them mandatory #123

Closed
11 tasks done
kanaka opened this issue Nov 30, 2015 · 16 comments
Closed
11 tasks done

Fix nested equality tests and then make them mandatory #123

kanaka opened this issue Nov 30, 2015 · 16 comments

Comments

@kanaka
Copy link
Owner

kanaka commented Nov 30, 2015

The following implementations fail the soft tests for nested equality. Sequence nested tests in step4 and hash-map nested steps in step9:

Once those are all fixed we should make those tests mandatory.
This was referenced Nov 30, 2015
Merged
Closed
dubek added a commit to dubek/mal that referenced this issue Nov 30, 2015
@dubek
guile: fix equality of hash-maps and lists/vectors
aeaad35 
As part of kanaka#116 and kanaka#123
@dubek dubek mentioned this issue Nov 30, 2015
Merged
@dubek
Copy link
Collaborator

dubek commented Nov 30, 2015

Guile fix in #124.

dubek added a commit to dubek/mal that referenced this issue Nov 30, 2015
@dubek
guile: fix equality of hash-maps and lists/vectors
d5995c7 
As part of kanaka#116 and kanaka#123
@kanaka
Copy link
Owner Author

kanaka commented Dec 2, 2015

I'll work on julia

@kanaka
Copy link
Owner Author

kanaka commented Dec 2, 2015

I'll take scala too.

@kanaka kanaka changed the title Fix embedded sequence equality tests and then make them mandatory Fix nested sequence equality tests and then make them mandatory Dec 2, 2015
kanaka added a commit that referenced this issue Dec 2, 2015
@kanaka
Scala: fix nested sequence/hash-map equality.
c6ff686 
Related to #123
@kanaka
Copy link
Owner Author

kanaka commented Dec 2, 2015

Okay, julia and scala fixes pushed. Also, I added some nested hash-map tests in addition to the nested sequences tests.

@kanaka
Copy link
Owner Author

kanaka commented Dec 2, 2015

I updated the list with all the implementation that fail the new nested equality tests (including forth and kotlin which are missing hash-map equality entirely).

@kanaka kanaka changed the title Fix nested sequence equality tests and then make them mandatory Fix nested equality tests and then make them mandatory Dec 2, 2015
@kanaka
Copy link
Owner Author

kanaka commented Dec 3, 2015

Fix bash and PHP in: 33d33bb (silly bugs really)

kanaka added a commit that referenced this issue Dec 3, 2015
@kanaka
Haskell: fix simple vector equality. Add test.
c46b421 
- Was missing vector to vector equality but never noticed because test
  was missing.
- Related to #123
@kanaka
Copy link
Owner Author

kanaka commented Dec 3, 2015

Haskell was an easy fix too.

ivern added a commit to ivern/mal that referenced this issue Jan 22, 2016
@ivern
Implemented hashmap equality (addresses kanaka#116, kanaka#123)
f8432eb
@ivern ivern mentioned this issue Jan 22, 2016
Closed
ivern added a commit to ivern/mal that referenced this issue Jan 22, 2016
@ivern
Implemented hashmap equality (addresses kanaka#116, kanaka#123)
de0023d
kanaka added a commit that referenced this issue Jan 22, 2016
@kanaka
Merge pull request #145 from ivern/kotlin
542e1d3 
Implemented hashmap equality (addresses #116, #123)
@ivern
Copy link
Contributor

ivern commented Jan 23, 2016

Kotlin should be updated to fixed now that it's merged.

@kanaka
Copy link
Owner Author

kanaka commented Jan 27, 2016

@jordanlewis @nlfiedler @ekmartin factor, erlang, and elixir are the remaining languages that still need this fix. Could you look at your respective implementation and fix the equality test when a sequence is embedded in another sequence? In other words, make these forms return true?

(= [(list)] (list []))
(= [1 2 (list 3 4 [5 6])] (list 1 2 [3 4 (list 5 6)]))

Thanks!

@jordanlewis
Copy link
Contributor

Sure I will take a look at this.

@ekmartin
Copy link
Contributor

Sure, I'll take a look.

@ekmartin ekmartin mentioned this issue Jan 27, 2016
Merged
dubek added a commit to dubek/mal that referenced this issue Feb 1, 2016
@dubek
tests: verify list/vector equality in hash-map values
163964a 
This is still in the soft-tests section of tests/step9_try.mal.

Issues: kanaka#116, kanaka#123
dubek added a commit to dubek/mal that referenced this issue Feb 1, 2016
@dubek
erlang: Fix nested list/vector/map equality
d4a84b2 
Issue kanaka#123
@dubek dubek mentioned this issue Feb 1, 2016
Merged
@kanaka
Copy link
Owner Author

kanaka commented Feb 1, 2016

Just factor left now.

@dubek dubek mentioned this issue Feb 1, 2016
Merged
@kanaka
Copy link
Owner Author

kanaka commented Feb 1, 2016

@jordanlewis don't worry about factor since @dubek just fixed it.

kanaka added a commit that referenced this issue Feb 1, 2016
@kanaka
Remove soft around nested equality tests
35ea7a9 
Related to issue #123
@kanaka
Copy link
Owner Author

kanaka commented Feb 1, 2016

Final thing is making the tests not soft tests. I just pushed that and will close this once travis gives the green light: https://travis-ci.org/kanaka/mal/builds/106320895

@jordanlewis
Copy link
Contributor

Thanks @dubek!

@kanaka
Copy link
Owner Author

kanaka commented Feb 1, 2016

All green. Closing.

@kanaka kanaka closed this as completed Feb 1, 2016
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@dubek
guile: fix equality of hash-maps and lists/vectors
f7b8ecc 
As part of kanaka#116 and kanaka#123
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@kanaka
Scala: fix nested sequence/hash-map equality.
30047c0 
Related to kanaka#123
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@kanaka
Haskell: fix simple vector equality. Add test.
983c99d 
- Was missing vector to vector equality but never noticed because test
  was missing.
- Related to kanaka#123
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@ivern
Implemented hashmap equality (addresses kanaka#116, kanaka#123)
e05dbd6
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@kanaka
Merge pull request kanaka#145 from ivern/kotlin
d0159e3 
Implemented hashmap equality (addresses kanaka#116, kanaka#123)
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@dubek
tests: verify list/vector equality in hash-map values
cd11715 
This is still in the soft-tests section of tests/step9_try.mal.

Issues: kanaka#116, kanaka#123
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@dubek
erlang: Fix nested list/vector/map equality
a81fe33 
Issue kanaka#123
micfan pushed a commit to micfan/make-a-lisp that referenced this issue Nov 8, 2018
@kanaka
Remove soft around nested equality tests
0f6c8c3 
Related to issue kanaka#123
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@dubek
guile: fix equality of hash-maps and lists/vectors
215a4f3 
As part of kanaka#116 and kanaka#123
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@kanaka
Scala: fix nested sequence/hash-map equality.
7e52a6b 
Related to kanaka#123
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@kanaka
Haskell: fix simple vector equality. Add test.
1f3211a 
- Was missing vector to vector equality but never noticed because test
  was missing.
- Related to kanaka#123
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@ivern
Implemented hashmap equality (addresses kanaka#116, kanaka#123)
6e7d7c3
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@kanaka
Merge pull request kanaka#145 from ivern/kotlin
b4df0a3 
Implemented hashmap equality (addresses kanaka#116, kanaka#123)
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@dubek
tests: verify list/vector equality in hash-map values
e7d99da 
This is still in the soft-tests section of tests/step9_try.mal.

Issues: kanaka#116, kanaka#123
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@dubek
erlang: Fix nested list/vector/map equality
5cd7b26 
Issue kanaka#123
luelista pushed a commit to luelista/mal that referenced this issue Mar 10, 2024
@kanaka
Remove soft around nested equality tests
9b91abf 
Related to issue kanaka#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dubek @ivern @jordanlewis @kanaka @ekmartin