Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock ruby version to 1.9.3. #175

Merged
merged 1 commit into from
Mar 4, 2013
Merged

Conversation

linjunpop
Copy link
Contributor

Because of https://github.com/kandanapp/kandan-count/blob/master/kandan-count.gemspec#L16

Also, When I push to Heroku:

       Gem::InstallError: kandan-count requires Ruby version >= 1.9.3.
       An error occurred while installing kandan-count (1.1.0), and Bundler cannot continue.
       Make sure that `gem install kandan-count -v '1.1.0'` succeeds before bundling.
 !
 !     Failed to install gems via Bundler.
 !
 !     Heroku push rejected, failed to compile Ruby/rails app

fusion94 added a commit that referenced this pull request Mar 4, 2013
@fusion94 fusion94 merged commit a40fa42 into kandanapp:master Mar 4, 2013
@mjtko
Copy link
Contributor

mjtko commented Mar 4, 2013

Does this mean we're dropping all requirements for Ruby 1.8.x syntax in the codebase, and can start using less hashrockets and more stabby lambdas etc?

@mjtko
Copy link
Contributor

mjtko commented Mar 4, 2013

I ask cos I keep catching myself using the colon hash syntax rather than hashrockets, and I'm a bit fed up of it. 😉

@fusion94
Copy link
Member

fusion94 commented Mar 4, 2013

@mjtko AFAIK Kandan won't even run with less anything other than that 1.9 so we should probably plan on a massive refactoring

@mjtko
Copy link
Contributor

mjtko commented Mar 4, 2013

Ok, thanks. I don't think supporting the current version (2.0.0) and the last major release (1.9.3) is anything other than what we should aim for anyway.

@fusion94
Copy link
Member

fusion94 commented Mar 4, 2013

Agreed, I've tested on 2.0 and until debugger gem supports it then we're stuck at 1.9

@mjtko
Copy link
Contributor

mjtko commented Mar 4, 2013

Well, tbh, we could work around that (I have been, as it doesn't support the latest 1.9.3 either) - debugger isn't required in most cases and we should be able to run test/production without it for sure.

@gabceb
Copy link
Member

gabceb commented Mar 4, 2013

I think we should work until debugger is out for 2.0. There is already a PR for it cldwalker/debugger#68

@linjunpop linjunpop deleted the ruby-1.9.3 branch March 5, 2013 00:41
ar7em pushed a commit to ar7em/kandan that referenced this pull request Jun 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants