Decouple configuration from assets #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| unless @_options? | ||
| @_options = $('body').data('kandan-config') | ||
| @_options.nowThreshold = 3000 | ||
| @_options.timestampRefreshInterval = 2000 |
There was a problem hiding this comment.
What do you think about adding these 2 settings to the Kandan::Config so we can have all settings in one place?
There was a problem hiding this comment.
Yup, sounds like a good idea. 👍
|
You can rebase this once we merge #212 and I'll merge it |
|
rebase this and ill merge it |
…ng, removing the coupling between rendered assets and the backend application configuration in place at time of rendering.
…l for consistency.
|
Haha, was already on it. 😁 |
gabceb
added a commit
that referenced
this pull request
Mar 14, 2013
…m-assets Decouple configuration from assets
|
🚢 'ed |
ar7em
pushed a commit
to ar7em/kandan
that referenced
this pull request
Jun 9, 2013
…ation-from-assets Decouple configuration from assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes that remove the need for .coffee.erb files in the assets, allowing the server configuration to be modified without needing the assets to be regenerated.
ie. removing the tight coupling between the configuration/environment at the time the assets are generated and the generated frontend application.