Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing link embedding sometimes messing up, fixed vimeo embed not matchi... #343

Merged
merged 1 commit into from
Apr 19, 2014

Conversation

scouttyg
Copy link
Member

...ng what Youtube embed does, and fixed image embedding not making sense

…ching what Youtube embed does, and fixed image embedding not making sense
@@ -1,6 +1,6 @@
class Kandan.Plugins.ImageEmbed
@options:
regex: /http.*\.(jpg|jpeg|gif|png)/i
regex: /http[\S]*\.(jpg|jpeg|gif|png)/i
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use a dot, then things like http://static.azgor.com/wp-content/uploads/octobiwan.jpg http://static.azgor.com/wp-content/uploads/octobiwan.jpg end up matching, even though they are two separate links. We should work off of non-space characters, vs all characters.

fusion94 added a commit that referenced this pull request Apr 19, 2014
Fixing link embedding sometimes messing up, fixed vimeo embed not matchi...
@fusion94 fusion94 merged commit 49f4125 into kandanapp:master Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants