Merge pull request #754 from kangax/issue-675

make options safe for structured cloning
kangax · Nov 19, 2016 · c29a430 · c29a430
2 parents 2ca9d86 + 7ee6ad8
commit c29a430
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/assets/master.js b/assets/master.js
@@ -4,6 +4,9 @@
   var minify = (function() {
     var minify = require('html-minifier').minify;
     return function(value, options, callback, errorback) {
+      options.log = function(message) {
+        console.log(message);
+      };
       var minified;
       try {
         minified = minify(value, options);
@@ -41,12 +44,8 @@
     [].forEach.call(byId('options').getElementsByTagName('input'), fn);
   }
 
-  function log(message) {
-    console.log(message);
-  }
-
   function getOptions() {
-    var options = { log: log };
+    var options = {};
     forEachOption(function(element) {
       var key = element.id;
       var value;

diff --git a/assets/worker.js b/assets/worker.js
@@ -5,7 +5,11 @@
   var minify = require('html-minifier').minify;
   addEventListener('message', function(event) {
     try {
-      postMessage(minify(event.data.value, event.data.options));
+      var options = event.data.options;
+      options.log = function(message) {
+        console.log(message);
+      };
+      postMessage(minify(event.data.value, options));
     }
     catch (err) {
       postMessage(err);