Skip to content

Commit

Permalink
Update .travis.yml (#1006)
Browse files Browse the repository at this point in the history
Remove unneeded stuff and add Node.js 10 and newlines.
  • Loading branch information
XhmikosR committed Mar 22, 2019
1 parent ce0e834 commit df65c0c
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,38 @@ addons:
- ubuntu-toolchain-r-test
packages:
- libstdc++-4.9-dev

branches:
only:
- gh-pages

language: generic

matrix:
fast_finish: true
sudo: false

env:
matrix:
- NODEJS_VER=chakracore/latest

This comment has been minimized.

Copy link
@alexlamsl

alexlamsl Mar 23, 2019

Collaborator

Why was this dropped?

node-chakracore release is currently up to 10.13.0, so it's not a deprecated Node.js platform per se.

It is always nice to test and catch any engine-specific bugs.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Mar 23, 2019

Author Collaborator

I honestly don't know a single person using it.

Because if we go this way, we'd need to test all the JS runtime projects out there, which are quite a few.

This comment has been minimized.

Copy link
@alexlamsl

alexlamsl Mar 23, 2019

Collaborator

Well I am using it, plus it gives some coverage to IE which can be hard to test otherwise.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Mar 23, 2019

Author Collaborator

IE is dead. And proper testing should be done on Browser Stack or similar anyway.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Mar 23, 2019

Author Collaborator

BTW apart from the above, of course you can add it back if it's of use for you.

- NODEJS_VER=node/4
- NODEJS_VER=node/6
- NODEJS_VER=node/8
- NODEJS_VER=node/10
- NODEJS_VER=node/latest

before_install:
- git clone --branch v1.4.2 --depth 1 https://github.com/jasongin/nvs.git ~/.nvs
- . ~/.nvs/nvs.sh
- nvs --version

install:
- nvs add $NODEJS_VER
- nvs use $NODEJS_VER
- node --version
- npm --version --no-update-notifier
- npm install --no-optional --no-save --no-update-notifier

script:
- npm test --no-update-notifier

notifications:
email: false

0 comments on commit df65c0c

Please sign in to comment.