Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeEmptyElements removes iframes #536

Closed
KenSharp opened this issue Mar 5, 2016 · 3 comments
Closed

removeEmptyElements removes iframes #536

KenSharp opened this issue Mar 5, 2016 · 3 comments

Comments

@KenSharp
Copy link

KenSharp commented Mar 5, 2016

It would appear that when removeEmptyElements is set to true, "empty" iframes are removed.

<iframe src='bacon.html'></iframe>

I know that it technically appears empty, but it really isn't. The attributes maketh the iframe.

This isn't true of frames:

<frame src='bacon.html'></frame>

...becomes:

<frame src=bacon.html>

Making the iframe "non-empty" stops it from being stripped:

 <iframe src='bacon.html'>iframe therefore I am</iframe>

Poor iframes.

@KenSharp KenSharp changed the title removeEmptyElements removed iframes removeEmptyElements removes iframes Mar 5, 2016
@alexlamsl
Copy link
Collaborator

On the bright side, I bet we've removed a lot of ads 😈

@KenSharp
Copy link
Author

KenSharp commented Mar 5, 2016

I wondered why embedded YouTube videos kept going missing....

I'm new to Github, I didn't realise every little thing I do would be logged against this ticket. 😳 I need to RTFM.

@alexlamsl
Copy link
Collaborator

No harm for that - and thanks for taking care of it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants