don't remove meaningful empty elements

[alexlamsl]

#536 mentions <iframe> - I've further identified <audio> and <video>.

[kangax]

Shouldn't video, audio and iframe act the same way as script? Only be removed when they don't have "src" attr?

[alexlamsl]

I was being conservative - but yeah let's go with yours.

Can you think of other tags while we are at this?

[alexlamsl]

@kangax commit amended

[kangax]

Perhaps <object>?

[alexlamsl]

Assuming <object data="..."> then?

[alexlamsl]

Right, added <applet code="..."> while we are at this.

[alexlamsl]

... I've just discovered <spacer> as well 😓

[alexlamsl]

Okay, looks like only Netscape and very old Mozilla browers support <spacer>, so I guess it's not a big deal...?

[kangax]

HTML is hard :D

On Sun, Mar 6, 2016 at 5:28 PM, Alex Lam S.L. notifications@github.com
wrote:

... I've just discovered as well [image: 😓]

—
Reply to this email directly or view it on GitHub
#538 (comment).

[alexlamsl]

I'm actually thinking about <i class="fa fa-camera-retro"> and same with <span> - they are commonly used to put out these font-based icons and removeEmptyElements would kill them.

[kangax]

Not sure it's worth adding support for spacer. It's deprecated, no?

[alexlamsl]

Probably not - it's one of those "no harm, let's throw in the kitchen sink" moment 👻

I'll take it back out then...

[alexlamsl]

So what are your thoughts on sparing <i> and <span> when class attribute is defined?

[kangax]

So what are your thoughts on sparing and when class attribute is defined?

That's expected. We should make it very clear in the docs. Ideally, they need to be ignored via config or something.

[alexlamsl]

I guess that link to your blog post has enough warning signs on it.

[alexlamsl]

<spacer> commit removed 😉

[kangax]

👍