Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag when processing large (> 500KB) files #675

Closed
tomasz1986 opened this issue Jun 26, 2016 · 5 comments · Fixed by #751
Closed

Lag when processing large (> 500KB) files #675

tomasz1986 opened this issue Jun 26, 2016 · 5 comments · Fixed by #751

Comments

@tomasz1986
Copy link

The minifier website freezes when processing large HTML files. It happens both in Firefox and Chromium but especially the latter gets completely frozen and has to be restarted to fix the issue. Firefox is usually responsive again after a few seconds.

Especially after processing one code, if I copy and paste a new code over the existing one and press "check" then the process gets stuck completely.

Is there anything that could be done about this?

@alexlamsl
Copy link
Collaborator

Minification is synchronous and runs on the main (UI) thread at the moment.

PRs to migrate to Web Workers (without losing browser compatibility) or general performance improvements are welcome.

@imvetri
Copy link

imvetri commented Jul 17, 2016

@alexlamsl I will be glad to implement, any guidance you could provide? regarding the development environment setup?

I am new to github community.

@alexlamsl
Copy link
Collaborator

@imvetri
Copy link

imvetri commented Jul 20, 2016

@alexlamsl Thanks.. very helpful.

@imvetri
Copy link

imvetri commented Jul 20, 2016

Hi @tomasz1986 , I am setting up development environment to try out idea suggested by Alex. (making minification asynchronous on browser side).

Would you mind sharing info how to use html-minifier on browser side? or any references to boilerplate projects will help me much.

Thanks :)

UPDATE 1: I figured it.. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants