Support multiple extensions on --file-ext #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses issues: #896 feature request: allow multiple file-extensions in CLI |
alexlamsl
reviewed
May 14, 2019
cli.js
Outdated
| @@ -262,7 +262,7 @@ function processDirectory(inputDir, outputDir, fileExt) { | |||
| else if (stat.isDirectory()) { | |||
| processDirectory(inputFile, outputFile, fileExt); | |||
| } | |||
| else if (!fileExt || path.extname(file) === '.' + fileExt) { | |||
| else if (!fileExt || fileExt.includes(path.extname(file).substring(1))) { | |||
There was a problem hiding this comment.
Please use ~fileExt.indexOf(path.extname(file).slice(1)) instead.
There was a problem hiding this comment.
Thanks. I wasn't aware Arrays.includes is an ES7 feature. :) Updated the pull request with an amend and a force push.
|
@kangax very sorry to bother you again, but looks like Travis can't build PR branches from forked repositories 😅 |
|
@kangax so I think given all the recent hassle, it's best if we:
... since it's better to have some progress than none at all. |
|
@kangax any luck? |
|
@alexlamsl sorry, been travelling. Wish I could just give you access to travis. I'll try to get to it today/tomorrow. |
|
@kangax @alexlamsl Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for multiple extensions on
--file-ext.For example:
This can filter out all supported extensions
html,htm,json,xml,yml,yamlin one go.