make removeOptionalTags more conservative #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased |
|
rebased again 👻 |
|
@kangax if you would publish |
kangax
added a commit
that referenced
this pull request
Feb 29, 2016
make removeOptionalTags more conservative
| equal(minify(input, { collapseWhitespace: true, removeOptionalTags: true }), output); | ||
|
|
||
| input = '<html><body></body></html> '; | ||
| output = ' '; |
There was a problem hiding this comment.
Hm, it's probably more theoretical than anything, but I wonder if we really care about leaving space in cases like this...
There was a problem hiding this comment.
These tests are for the benefit of keeping track of this tricky logic than of any real world importance, I agree.
Pretty sure most people can't tell an empty screen from one with a whitespace on it 👻
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #503, we should treat all HTML tags around non-standard tags as mandatory.
They might get transformed by JavaScript libraries into various locations of the final DOM tree, which may or may not break the optional tag rules.