Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bootstrap CSS to benchmarks #587

Merged
merged 2 commits into from Mar 26, 2016
Merged

add bootstrap CSS to benchmarks #587

merged 2 commits into from Mar 26, 2016

Conversation

alexlamsl
Copy link
Collaborator

@XhmikosR as per request 馃槈

In this particular benchmark we are far behind Will Peavy - 269KB vs 233KB.

@XhmikosR
Copy link
Collaborator

@alexlamsl: what options did you use? The only reason I can think of is will peavy having a bug and breaking the <pre> code.

@alexlamsl
Copy link
Collaborator Author

@XhmikosR benchmark.js uses sample-cli-config-file.conf as options.

To begin with, they took out one of the two chunks of IE Conditional Comments.

Further inspecting the result I see snippets like </pre>0</figure>, </pre>1</figure>, ... 130 of them in total, which cannot be found in the original document. Chunks of markups may be getting uber-compressed into these magic numbers 馃槈

@XhmikosR
Copy link
Collaborator

Yeah, told you, it's the most logical explanation since it has many code snippets.

@alexlamsl
Copy link
Collaborator Author

Sometimes I wish you or @kangax would just let me output an empty string - would reduce a lot of code complexity and makes the whole project so much more maintainable 馃懟

I even have this idea of achieving larger-than-100% compression by randomly removing local files every time cli.js is run, but I guess that's probably over-kill...

@alexlamsl
Copy link
Collaborator Author

Jokes aside - anything else you want me to do on this task @XhmikosR ?

@XhmikosR
Copy link
Collaborator

Looks good to me, hoping for a completely automated solution in the future which will grab the pages each time :)

@alexlamsl
Copy link
Collaborator Author

That and auto-update README.md after each run 馃槑

@alexlamsl alexlamsl merged commit ee9358c into kangax:gh-pages Mar 26, 2016
@alexlamsl alexlamsl deleted the benchmark-bootstrap branch March 26, 2016 16:23
@alexlamsl alexlamsl mentioned this pull request Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants