sort style classes #597
Merged
sort style classes #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ### Sorting attributes / style classes | ||
|
|
||
| Minifier options like `sortAttributes` and `sortClassName` won't impact the plain-text size of the output. However, they form long repetitive chains of characters that should improve compression ratio of gzip used in HTTP compression. | ||
|
|
There was a problem hiding this comment.
|
Looks great. I would just rename |
|
@kangax the rebase was fun (since the file was introduced in the very first commit), but it's all done 馃槑 |
|
馃憤 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So rather than going with a simplistic global frequency count, this optimises for longest chain output.
Similar to #594, we get some savings in compressed outputs in most cases. What surprised me was the Google benchmark 馃槷
Usual warning about my choice and taste of variable names - suggestions welcome 馃槗
TODOs:
chain.jstosortAttributessortAttributesandsortClassName