Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise HTML entity characters #608

Merged
merged 1 commit into from
Apr 7, 2016
Merged

optimise HTML entity characters #608

merged 1 commit into from
Apr 7, 2016

Conversation

alexlamsl
Copy link
Collaborator

Also fixes an existing problem where <div style="&quot;"> would have the semi-colon stripped.

@alexlamsl alexlamsl mentioned this pull request Apr 7, 2016
@@ -23,15 +23,15 @@ How does HTMLMinifier compare to other solutions — [HTML Minifier from Will Pe
| [HTMLMinifier page](https://github.com/kangax/html-minifier) | 49 | **37** | 42 | 44 | 43 |
| [NBC](http://www.nbc.com/) | 91 | **74** | 84 | 85 | 85 |
| [ES6 table](http://kangax.github.io/es5-compat-table/es6/) | 118 | **80** | 93 | 93 | 94 |
| [New York Times](http://www.nytimes.com/) | 131 | **101** | 122 | 125 | 120 |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh come on, we're not even letting our competitors to catch up!!! 😆

@kangax
Copy link
Owner

kangax commented Apr 7, 2016

LGTM!

fix trailing semi-colon removal in style attributes
fixes #75
fixes #472
@alexlamsl alexlamsl merged commit 18ec835 into kangax:gh-pages Apr 7, 2016
@alexlamsl alexlamsl deleted the issue-75 branch April 7, 2016 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants