upgrade to clean-css 4.0 #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean-css 4.0.0
alexlamsl
force-pushed
the
clean-css-4
branch
from
d5c5f9d
to
917d220
Compare
|
I haven't looked v4. Do they have advanced optimizations disabled by default? |
|
@XhmikosR that is indeed the case. https://github.com/jakubpawlowicz/clean-css#optimization-levels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed workarounds put in place for previous versions of
clean-css, namely HTML comment wrapper and manual disabling ofadvancedoptimisations.Even though the configurations for
clean-csshas been renamed and rearranged drastically,html-minifierwith its defaultminifyCSS: truebehaviour should be identical as before. So I am thinking of a minor version bump forhtml-minifier./cc @kangax @XhmikosR